Repository navigation
Conversation
JJenkx
force-pushed
the
perf/combined-descriptor-binds
branch
from
October 14, 2026 15:59
a3b64e3 to
ee8f266
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Split graphics resources bind descriptor sets 0 and 1 with two
vkCmdBindDescriptorSetscalls. Bind the two consecutive sets in one call when both exist, preserving set order, handles, bind point, and pipeline layout. Main-only, fragment-only, and empty cases retain their behavior. Use the same helper for ordinary resources and per-draw snapshot bindings.The current refresh preserves main’s image-descriptor mock handling and all image-table tests. The helper statically requires the fragment descriptor set to remain set 1.
Tested
Refreshed as one commit on main
763ad20fc19. Release builds of the graphics and draw-cache-reuse tests pass. Both executables pass on RADV/Radeon and lavapipe: four invocations passed, no whole-test skips. The graphics suite includes the split-resource bind assertions for two sets, each single set, and no sets. Heap-mirror subchecks report unavailable without a write-watched guest arena and are not counted as validated.Conventions and whitespace checks pass. No matched title performance comparison, Windows build, or full-suite run has been completed on this refresh. The reduced command count does not establish a gameplay FPS improvement.
Checklist